Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all video thumbnails in one frame in viewerType.scrollable #181

Open
Helocominc opened this issue Oct 30, 2022 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@Helocominc
Copy link

If the TrimViewer type is set to ViewerType.scrollable the video thumbnail doesn't display on a single frame if maxVideoLength is provided. Only the provided maxVideoLength portion is shown in the thumbnail.

Platform: Android
Version: video_trimmer 2.0.0

@sbis04
Copy link
Owner

sbis04 commented Oct 30, 2022

Yeah, that's expected behavior. maxVideoLength specifies the maximum length the trimmed video can have. If you don't want to limit the length of the trimmed video, use ViewerType.fixed. Let me know if I didn't interpret your question properly.

@Helocominc
Copy link
Author

I tried using ViewerType.fixed but the trimmer doesn't move over the thumbnails.

@sbis04
Copy link
Owner

sbis04 commented Oct 30, 2022

Okay, got it. So, it's basically related to your previous issue (#178). Probably something like a scrollable trimmer without a max length limit should work then I guess?

@Helocominc
Copy link
Author

Helocominc commented Oct 30, 2022

I just want it to have a max length and then move around on drag. With all the thumbnail in one frame. Whatsapp have same functionality.

@sbis04 sbis04 added the enhancement New feature or request label Nov 5, 2022
@Helocominc
Copy link
Author

@sbis04 Any update based on my request?. It's important

@Helocominc
Copy link
Author

@sbis04 please any progress for this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants