Implement Data in Modules #325
Conversation
SimonHoenscheid
commented
Mar 28, 2022
•
SimonHoenscheid
commented
- move all defaults to data directory
- remove params.pp class file
- client and server are now private classes
- this PR is a breaking change, due to the fact client and server class are no longer usable directly
- closes Feature Request: Add Support for Data in Modules #323
…er are now private classes.
|
Thanks for the PR! I'm thinking about the change of Maybe it makes sense, to add a parameter to disable management of one or the other part? |
|
One option would be to add two parameters in the ssh class which would default to true. If a user decides to use the classes directly he would need to set the variable to false in hiera to avoid the duplicate declaration. An other option would be, just to include the classes and auto bind the default parameters via hiera, that would also remove every duplicate declaration The third option is the one that is used in the PR. Which is the one closest to best practice. |
* Update puppet-tripleo from branch 'master'
to b74e4af57f54f440128c6d5663ab7767d2ac1629
- Merge "Do not include the ssh::server class directly"
- Do not include the ssh::server class directly
... to avoid the duplicate declaration of the ssh::server class we've
seen since saz/puppet-ssh#318 was merged.
There is an open PR[1] in puppet-ssh repo, which makes the server
class private. This change also works as pre-emptive fix for that
breaking change.
[1] saz/puppet-ssh#325
Closes-bug: #1966625
Change-Id: I9c5b174e0c8377d50b9b306456d2b2147c5f38b8
Signed-off-by: Bogdan Dobrelya <[email protected]>
... to avoid the duplicate declaration of the ssh::server class we've seen since saz/puppet-ssh#318 was merged. There is an open PR[1] in puppet-ssh repo, which makes the server class private. This change also works as pre-emptive fix for that breaking change. [1] saz/puppet-ssh#325 Closes-bug: #1966625 Change-Id: I9c5b174e0c8377d50b9b306456d2b2147c5f38b8 Signed-off-by: Bogdan Dobrelya <[email protected]>
|
@saz how do you want to handle this? |
|
@saz ping ;-) |
