-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@1.49.9 Skipped not serializable cache item 'Compilation/modules #2060
Comments
Duplicate of #2059. See #2059 (comment) |
Perhaps this change should be pushed back to a later release, and a deprecation warning be emitted instead? Disallowing function names like Otherwise, it would likely be helpful to add a warning if a user tries to either create a function with one of the newly reserved names or if a user tries to call one of these newly reserved functions while a user-defined function of the same name is in scope. |
I just ran into this as well and it took me as a surprise as I would consider this a breaking change. Why are these new functions not functions like |
Sass performs simplification of these sorts of functions, so they're type-checked to what the browser expects and have special behavior when possible. See an example of this here (note this repl doesn't yet support these new functions). |
I agree, this potential issue wasn't caught during the proposal nor implementation. It's a lesson to be learned for an issue that I think will reappear for the Color Level 4, New Color Spaces proposal. (for example, the new Natalie is currently out, we're waiting for her return before any further releases :) Personally (and this is not authoritative) I agree it should have been pushed back with a deprecation warning period, or rolledback into 1.65.2 immediately. Now I feel it is "too late" and reverting would break those who made changes in response to this version which has been out for almost a week, so reverting is more difficult. I imagine something in between like "if there is a calc function available as a function without a namespace, don't parse as calculation and evaluate as function and print a warning". Not sure if that's the path we'll take.
https://sass-lang.com/documentation/breaking-changes/calc-functions/
Functions like Before the breaking change, functions like |
FWIW, looking for something else for an unrelated issue, I stumbled upon this relevant bug report for the same problem with min/max 🤔 |
For some reason I thought Thanks for all the explanations, I can understand what happened. Renaming the function and retraining some muscle memory is probably the simplest solution, although I do feel like a bunch of people were caught quite off-guard by this. |
I've reopened sass/sass#3504 to track this. |
Hi, currently getting below error with my production build compilation, Can someone suggest me to handle this?
Failed to compile.
The text was updated successfully, but these errors were encountered: