Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some hacking for ease of use and output #12

Open
varioustoxins opened this issue Oct 5, 2022 · 1 comment
Open

some hacking for ease of use and output #12

varioustoxins opened this issue Oct 5, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@varioustoxins
Copy link

I have adapted the code so

  1. I have a function that builds spin system matrices from shifts, degeneracy and coupling
  2. I have modified the output routines so you can plot to a file
  3. I have added the ability to pass parameters to the plotting

Is it worth me converting these into pull requests

finally is it possible to isolate the lien components for each chemical shift so they can have different line widths (I could even imagine this being useful on a per multiple component level...

regards
gary

@varioustoxins varioustoxins added the enhancement New feature or request label Oct 5, 2022
@sametz
Copy link
Owner

sametz commented Oct 11, 2022

Hi! Is it possible to see what you've done? (e.g. link to fork).

Part of the reason this is still Version 0 is because the API may change to make it more user-friendly, so this could be of interest.

I've been debating whether the library should contain plotting routines, since people have their favorite libraries. But, since matplotlib is more or less the Python default, I'm keeping them for now. So, your plotting work could be interesting.

I'm not sure what "lien components" refers to, but I take this to mean you want the option of having different line widths for different signals within a second-order calculation? I think would be possible, but it would be a niche option. I think it could already be done if you manually construct Lorentzians for the subcomponents, with different line widths, and add them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants