Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing for to_0x_hex_str #1545

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Improve typing for to_0x_hex_str #1545

merged 1 commit into from
Feb 4, 2025

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Feb 4, 2025

  • It's returning an HexStr

@Uxio0
Improve typing for to_0x_hex_str
25e22a0 
- It's returning an `HexStr`
@Uxio0 Uxio0 requested a review from a team as a code owner February 4, 2025 15:30
@coveralls
Copy link

coveralls commented Feb 4, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13138974680

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 93.967%
Files with Coverage Reduction New Missed Lines %
safe_eth/eth/tests/clients/test_etherscan_client.py 1 90.91%
Totals Coverage Status
Change from base Build 13137315251: 0.01%
Covered Lines: 9486
Relevant Lines: 10095
💛 - Coveralls

@Uxio0 Uxio0 merged commit f8daea1 into main Feb 4, 2025
7 checks passed
@Uxio0 Uxio0 deleted the fix-typing-hexstr branch February 4, 2025 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @falvaradorodriguez