Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop file should be named after the app name #221

Open
Bonjour123 opened this issue Dec 18, 2024 · 2 comments
Open

Desktop file should be named after the app name #221

Bonjour123 opened this issue Dec 18, 2024 · 2 comments

Comments

@Bonjour123
Copy link

First, thank you for your commitement to the project :)

[PROPOSED IMPROVEMENT]

Desktop file should be named after the app name.

Currently, with this settings:
image

Here is the Desktop file name I get:

com.github.ryonakano.pinit.44a35a5c-587b-4a81-ba8d-a1a9b61dbb7f.desktop

whereas I should have:

pomatez.desktop

Also, the location of the desktop file should be displayed so the user can find it easily.

@ryonakano
Copy link
Owner

Thank you for using the app and your proposal!

The app names desktop files in the form of com.github.ryonakano.pinit.<UUID>.desktop at the moment because naming them after the app name would make things a little complicated:

  • What should we do if a user changes the app name?
    • Rename the desktop files too? But what about if a file that has the filename after rename already exists?
  • What should we do if a user set the same app name to multiple entries?
    • Name like appname_1.desktop?

This app aims to manage desktop entries without file managers so that users don't need to know that they are saved in files.

@Bonjour123
Copy link
Author

Hi, thank you for your time.
For the first point, I guess if the user already renamed the file it's because he knows where the file is, and decided of a particular name that is NOT the one of the app (since if it was the case he wouldn't have had to rename it). So I think we shouldn't touch it if it already has been renamed.

About the second point, yes, I think naming it with an extra counter to deal with duplicates is a good solution, quite common in UX so the user wouldn't be surprise.

Also there is maybe the simpler solution to simply display the absolute path of the desktop file, which would solve the original problem, i.e. to be able to find the file and modify it at will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants