-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Conformalised Quantile Regression #12
Comments
To implement conformalised quantile regression we added a new function called conformal.quant.forest. We chose Random Forest as quantile regression method, since, by our tests it proved to be more reliable The function takes as input: The function returns a list with the following components: lo, up, split. The first two We also built an example script, called ex.conformal.quant.forest, to test the code, similarly to the already |
@paolo-vergo Sorry for the long delay. I'm generally happy/excited to add new conformity measures, especially the quantile-based ones since they seem to work so well in practice. But I'm unclear about the right way to structure it is, in the package. Currently, all the functions What you're proposing is to provide a function that fixes the conformity measure to be the quantile-based one, and also fixes the training/prediction algorithm to be a random forest. That seems to break with the functional style of the rest of the package, so I'd at least like to pursue some more generality. Two options are as follows.
Thoughts? We could also see what people are doing in any relevant Python implementations, to gain some perspectives from that. |
Hi @ryantibs ! Since I am about to graduate and I do not have much time left, we would go for the first option. In particular we have already implemented conformal.quant() and conoformal.quant.split(). |
Sounds good @paolo-vergo. Why don't you submit a PR, but just be warned that it may end up sitting on a branch for a while. I'm just trying to be realistic, because as you can see, I've been extremely slow in being able to find time to merge your existing PRs, which again I'm quite sorry for, and I've not been able to find anybody to help (I was seeing if I could find interested students or community members to help manage the package and tend to issues and pull requests, but haven't been successful yet). So I don't think realistically I'll be able to get to this new PR any time soon, before you graduate. And since the more general solution that I outlined in bullet point 2 in my last message seems like the more desirable general solution, I may try to find some time to refactor the package and eventually accomplish this more general structure. |
Ok @ryantibs. I'll proceed with a PR! |
It would be interesting to implement Conformalised Quantile Regression (Romano et al 2019) (https://arxiv.org/abs/1905.03222).
This could be done via the implementation of other Non-Conformity Measures
The text was updated successfully, but these errors were encountered: