Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Allow to override the internal instance of HttpClient used to download and stream media #1392

Open
danielgomezrico opened this issue Jan 27, 2025 · 0 comments
Assignees
Labels
1 backlog enhancement New feature or request

Comments

@danielgomezrico
Copy link

danielgomezrico commented Jan 27, 2025

Is your feature request related to a problem? Please describe.

Yes, the current implementation does not allow overriding the internal HttpClient used for making requests. This limitation prevents us from integrating tools like Datadog or Firebase Performance Monitor to observe, log, and analyze HTTP requests. Without this capability, it is challenging to track and optimize network performance effectively.

Describe the solution you'd like

I would like the ability to override or configure the HttpClient that your library uses internally for making HTTP requests. This would enable developers to inject custom HttpClient instances, which could include necessary integrations (e.g., handlers or interceptors) for tools like Datadog or Firebase Performance Monitor.

Describe alternatives you've considered

  • I can use HTTP Overrides without this, but it seems harder than supporting it from the library itself.
  • Send the custom HttpClient on the constructor the Player
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants