Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferList.js as independent module #85

Closed
jeromew opened this issue Apr 27, 2020 · 2 comments
Closed

BufferList.js as independent module #85

jeromew opened this issue Apr 27, 2020 · 2 comments

Comments

@jeromew
Copy link

jeromew commented Apr 27, 2020

Hello,

In order to write a protocol parser with chunky behaviors I am searching for an efficient BufferList implementation that keep the original buffers intact and that copies things only when it is necessary. https://github.com/rvagg/bl/blob/master/BufferList.js would be perfect for that but I understand that since bl v1.0, in order to use it, I also need to import readable-stream via package.json which is not necessary in some cases.

Would you consider publishing BufferList.js as an independent package for those who do not need the streaming aspect of it ? I think that could also create an easier migration path for the packages that depend on old versions (mentioned in #52)

What do you think would be the best way forward ?

@mcollina
Copy link
Collaborator

What harm does downloading readable-stream do? You can avoid loading it by doing require('bl/BufferList').

@jeromew
Copy link
Author

jeromew commented Apr 27, 2020

You are right I agree that readable-stream will probably be downloaded anyway in many applications so it probably makes more sense your way.
Thanks

@jeromew jeromew closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants