Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dyn keyword required on 0.2.85 #3450

Closed
bobbobbio opened this issue May 24, 2023 · 1 comment
Closed

dyn keyword required on 0.2.85 #3450

bobbobbio opened this issue May 24, 2023 · 1 comment
Labels

Comments

@bobbobbio
Copy link

Starting with 0.2.85, in at least this one particular instance the wasm_bindgen macro seems to need the dyn keyword to compile correctly, and otherwise it gives a strange error. For specifics see this compilation error with stdweb koute/stdweb#427

I guess this is a breaking change but I'm not sure if this was intentional or not. I think the dyn keyword isn't required on all editions, but I'm not sure what editions are suppose to be supported.

If the answer is stdweb just needs to be updated, then this can be closed.

@bobbobbio bobbobbio added the bug label May 24, 2023
@daxpedda
Copy link
Collaborator

Duplicate of #3415.

The problem is syn in this case, it correctly requires to use the dyn keyword when writing trait objects like this. This happened because of the upgrade to v2 of syn, so there is nothing we, as in wasm-bindgen, can really do here. This should be fixed in stdweb.

@daxpedda daxpedda closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants