Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

One lock per file #1329

Open
Xanewok opened this issue Feb 25, 2019 · 2 comments
Open

One lock per file #1329

Xanewok opened this issue Feb 25, 2019 · 2 comments
Labels
enhancement Indicates new feature requests package: rls-vfs

Comments

@Xanewok
Copy link
Member

Xanewok commented Feb 25, 2019

Originally created by @nrc (rust-dev-tools/rls-vfs#2):

Currently we have one lock for the whole VFS which is not very efficient.
@Xanewok
Copy link
Member Author

Xanewok commented Feb 25, 2019

Originally replied by @matklad (rust-dev-tools/rls-vfs#2 (comment)):

Perhaps just change Mutex to RwLock? I don't expect there to a lot of parallelism: modification requests should be serialized anyway, and I think most editors (IDEA for sure) already serialize edition operations on their side.

@Xanewok
Copy link
Member Author

Xanewok commented Feb 25, 2019

Originally replied by @nrc (rust-dev-tools/rls-vfs#2 (comment)):

We no longer hold the mega-lock for any file-system operations. So this is not so urgent any more. Should probably still change to RWLock.

@Xanewok Xanewok added the enhancement Indicates new feature requests label Mar 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Indicates new feature requests package: rls-vfs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xanewok