Suggest std::sync::LazyLock instead of once_cell::sync::Lazy
#1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx!! Do we really want to mention 3rd party crates when the exact same functionality is available in stdlib? |
gibfahn
reviewed
Jan 31, 2025
Comment on lines
+83
to
+86
| they're used from inside a helper function. Instead, we recommend using | ||
| [`std::sync::LazyLock`] stabilized in [Rust 1.80], the [`once_cell`] crate, or | ||
| the [`lazy_static`] crate to ensure that regular expressions are compiled | ||
| exactly once. For example: |
There was a problem hiding this comment.
Is there a reason not to just use the LazyLock option? As a user without much idea on the history, it would be nice if there was just one standard and recommended option, the stdlib one.
Also the one that clippy recommends: https://rust-lang.github.io/rust-clippy/master/index.html#non_std_lazy_statics
|
I found this PR (eventually) because clippy now has a pedantic lint against lazy_static: https://rust-lang.github.io/rust-clippy/master/index.html#non_std_lazy_statics Would be nice to get this landed so it's easy for folks who see that lint to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests
std::sync::LazyLockinstead ofonce_cell::sync::Lazy.This issue was discussed three months ago right after the stabilization of
std::sync::LazyLockin Rust 1.80,and since two more minor versions of Rust have been released since then,
I think it's about time.
Many thanks,
Closes #1217