Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign values to RecoveryId #777

Open
Kixunil opened this issue Jan 27, 2025 · 0 comments
Open

Assign values to RecoveryId #777

Kixunil opened this issue Jan 27, 2025 · 0 comments

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Jan 27, 2025

Currently we have just the names making the values implicit. This is not strictly wrong but it really feels like implicit property even though we actually explicitly want the values to behave as they are written. Assigning explicit values (Zero = 0 etc) makes that intention clear.

We can also use as instead of match in the From impl to convey that this is intentional. (Might also help with debug performance.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant