-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RecoveryId
getters
#774
Comments
I don't think we need If we currently have |
Also A constructor for consideration though: |
Oh, I like that idea. |
Should it take a let recid = RecoveryId::from_i32(((bytes[0] - 27) & 0x03) as i32)?; |
Let's say a |
That expression is also silly. It takes a byte, transforms it to a different byte then converts it to |
Well, given the existing API it's not too silly :P. But yes, we should fix the API so we can fix it. |
Add two getters to the
RecoveryId
typeto_u8()
to_u32()
Original mentioned here: #765 (comment)
For anyone that wants to know why we add getters to int types and not setters, its because the type of
From
often cannot be inferred so the explicit getter is more ergonomic.The text was updated successfully, but these errors were encountered: