Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Vector3 needed? #17

Open
peci1 opened this issue Mar 24, 2020 · 0 comments
Open

Is Vector3 needed? #17

peci1 opened this issue Mar 24, 2020 · 0 comments

Comments

@peci1
Copy link

peci1 commented Mar 24, 2020

I've just stumbled upon the docs that say:

These issues arise only with fixed-size vectorizable Eigen types and structures having such Eigen objects as member. For other Eigen types, such as Vector3f or MatrixXd, no special care is needed when using STL containers.

Indeed, the list of vectorizable types only contains Vector2 and Vector4, not Vector3.

If I'm not missing something, it seems that the using the EigenSTL version of vector of Vector3's doesn't bring anything. I understand that removing the typedef would not be a good idea, but maybe leaving a few comments around in the readme and the .h file might save someone some hesitations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant