Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electrs logs report "less efficient method of querying" electrs server #652

Open
Overtorment opened this issue Jan 7, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@Overtorment
Copy link

We have an issue: BlueWallet/BlueWallet#4336

Probably electrs wants us to always connect, keep connection alive and subscribe to all scripthashes we are interested in.
In BW we dont subscribe, as user sessions might be very short, so we try our best to quickly connect, query about scripthashes, and then dont care if user terminates the app or connection closes (which happens when user suspends the app on iOS. OS simply closes all sockets of suspended apps)

@Overtorment Overtorment added the bug Something isn't working label Jan 7, 2022
@Kixunil
Copy link
Contributor

Kixunil commented Jan 7, 2022

I guess ignore the warning then?

Anyway, may be interesting if we had some alternative notification mechanism so that electrs could wake up the app (e.g. by POSTing to some notification server). This would require extending the protocol and maybe even authentication. What do you think @romanz?

@romanz
Copy link
Owner

romanz commented Jan 8, 2022

I prefer to refactor the code so the index-related functionality will be in a seprarate crate from the RPC-related functionality.
Then, it would be possible replace the whole Electrum RPC with something more REST-like, similar to how it's done in https://github.com/bwt-dev/bwt/blob/5f92c4717bdc474302305823dcf60fd3425ba8c0/src/webhooks.rs#L27.

@niteshbalusu11
Copy link

niteshbalusu11 commented Apr 26, 2022

Is there a timeline on when this will be worked upon?
Right now I'm facing an issue, if I import a wallet into BlueWallet that has a long history of past transactions and try to refresh the list, electrs sometimes crashes with a long list of this error in the logs.

@caheredia
Copy link

I'm seeing the same logs with Sparrow wallet

@crcastle
Copy link

I'm getting many log messages reporting this while using Liana wallet. I opened an issue with Liana so they are aware they are using a "less efficient method of querying" electrs: wizardsardine/liana#1574

It looks like Liana uses the bdk client library and that project knows of this issue

But I'm getting thousands of these log messages from electrs with Liana open for an hour or so. Not a major issue, but it might be nice to rate limit that log message to keep the duplicate log lines from making it difficult to find or notice other log messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants