-
Notifications
You must be signed in to change notification settings - Fork 91
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rodgc/ngx-socket-io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.8.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rodgc/ngx-socket-io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 7 files changed
- 3 contributors
Commits on Dec 27, 2024
-
Export SOCKET_CONFIG_TOKEN (#188)
This is needed if one needs to extend a basic configuration with namespaces, for example.
Configuration menu - View commit details
-
Copy full SHA for 64774f4 - Browse repository at this point
Copy the full SHA 64774f4View commit details -
Fix and sync api wrapper (#190)
* Fix socket.of() method Socket-io's of() only exists in the server API and it returns a new instance. For client we must create a new `io()` with the URL containing the namespace. Let's do this and share instances whenever the namespace is reused. * Fix chaining methods Since we're wrapping the socket, we must return ourselves and not the internal socket. * Fix volatile usage It's a getter that toggles a flag, but then we must return the actual instance * Add return types to help users Since we're not importing socket.io-client typings, these are particularly important to avoid `any` * Add emitWithAck() * Add offAny() and offAnyOutgoing() These match onAny() and onAnyOutgoing() * Add send() Basically emit('message', ...args) * Add compress() * Add attributes * Fix connect() and disconnect() arguments According to https://github.com/socketio/socket.io/blob/main/packages/socket.io-client/lib/socket.ts and https://socket.io/docs/v4/client-api/ these functions do not receive any arguments.
Configuration menu - View commit details
-
Copy full SHA for 0cda11e - Browse repository at this point
Copy the full SHA 0cda11eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5f9d72 - Browse repository at this point
Copy the full SHA d5f9d72View commit details
Commits on Feb 8, 2025
-
* Fix: off() takes a single function, not array * Fix and lock typescript typings The previous attempt to manually sync missed some details, then remove the outdated @types/socket-io and use the built-in types instead. Then do a mapping of the original IoSocket type to the wrapped, forcing the wrapper to be returned for chained, properties should alway match. This will force the wrapper to be in sync without much effort. * Breaking: mark internal fields as private, all as readonly None of these fields should be reassigned once they are created, so they are all readonly. Except by ioSocket, all are of internal use, so keep them private. * Breaking: fix off() behavior, sync with socket-io-client off() without an event name just unregisters all event handlers via EventEmitter. The comment implied offAny() would do this, but it's not the case: that just removes the onAny() handlers. If we really wanted to remove all event handlers for everything we should be calling: - offAny() - offAnyOutgoing() - off() But that would not match the wrapped behavior, so let's just keep it simple.
Configuration menu - View commit details
-
Copy full SHA for 04f35ac - Browse repository at this point
Copy the full SHA 04f35acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d07da8 - Browse repository at this point
Copy the full SHA 1d07da8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77d16a2 - Browse repository at this point
Copy the full SHA 77d16a2View commit details
Commits on Feb 9, 2025
-
The options property in the SocketIoConfig interface has been updated…
… to use Partial<ManagerOptions> instead of a custom-defined object:
Configuration menu - View commit details
-
Copy full SHA for 88a0dc5 - Browse repository at this point
Copy the full SHA 88a0dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fff31a - Browse repository at this point
Copy the full SHA 0fff31aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c07677b - Browse repository at this point
Copy the full SHA c07677bView commit details
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.