Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mstatus SXL/UXL issues #702

Closed
Timmmm opened this issue Jan 29, 2025 · 3 comments
Closed

Mstatus SXL/UXL issues #702

Timmmm opened this issue Jan 29, 2025 · 3 comments

Comments

@Timmmm
Copy link
Collaborator

Timmmm commented Jan 29, 2025

Just so we don't forget, #652 accidentally made mstatus.SXL/UXL non-zero on RV32 which is incorrect. Fix in #683

Also an existing issue is that they should be read-only zero if the corresponding mode is not implemented. That will be fixed in a future PR.

@radimkrcmar
Copy link
Contributor

I already have the patches for both issues. No idea how to write tests for them, though.

@Timmmm
Copy link
Collaborator Author

Timmmm commented Jan 29, 2025

Tests, shmests... :-D

Once the CMake PR is merged I'm going to add support for Sail unit tests so we can at least do some testing of things.

Both of those things should probably actually be ELF tests rather than unit tests but getting that up and running is way more work, and adds a RISC-V compiler as a dependency which would be nice to avoid if possible.

I almost think this domain needs a new programming language that is like "high level assembly" with a compiler & linker that are very easy to distribute (single statically linked executable). C and assembly are both rubbish for low level tests and benchmarks.

@Timmmm
Copy link
Collaborator Author

Timmmm commented Feb 3, 2025

Both issues should be fixed now via #597.

I'm working on adding nice unit tests support to Sail to test this sort of thing: rems-project/sail#928

@Timmmm Timmmm closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants