Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking #91

Open
leenozara opened this issue May 5, 2020 · 3 comments
Open

Benchmarking #91

leenozara opened this issue May 5, 2020 · 3 comments

Comments

@leenozara
Copy link
Contributor

When changes to kernel and system modules are made, as well as changes to dependencies, we should run a series of standard benchmarks. These would include both rust/cargo benchmarks and common actor system benchmarks (such as Ring Token and Skynet).

These tests would provide a benchmark between riker versions to ensure changes made don’t impact performance.

Additionally, benchmarks could be made between different actor systems both rust based and Scala, Erlang, C++, etc. This is less of a priority however at this point.

See:
https://arxiv.org/pdf/1505.07368.pdf
https://github.com/actor-framework/benchmarks

@hardliner66
Copy link
Contributor

I might be wrong, but I think something like #58 is needed for some/most of these benchmarks in order to get the time from system start to system end. The tutorials currently solves this by using Thread::sleep(), which shouldn't be used in benchmarks. Otherwise we are only measuring the Thread::sleep.

@leenozara
Copy link
Contributor Author

It may be that what’s being tested doesn’t include system start and end, since that would skew the results favoring systems that have high start/end times, regardless of test.

In any case though, the usage of Thread::sleep() throughout the project does need to be replaced as per #58. Testing overall really needs this as CI build times are becoming longer, since some (many?) tests involve some sleep.

@hardliner66
Copy link
Contributor

You are correct. I didn't think about tests not involving startuptime. Though I do think that we need a benchmark for that in order to show more complete performance numbers.

Depending on the use-case startup time can be a big factor. If I write a server which runs for weeks/months/years, startup time doesn't really matter. If I write a desktop application or something on embedded, it might matter more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants