Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with XLS files #148

Open
mthh opened this issue Jan 31, 2025 · 2 comments
Open

Issue with XLS files #148

mthh opened this issue Jan 31, 2025 · 2 comments
Labels
bug It's a bug and we should do something about it.

Comments

@mthh
Copy link
Member

mthh commented Jan 31, 2025

Files in XLS format seem to fail to open.
Files in XLSX, ODS or CSV formats are not affected and open correctly.
@mthh mthh added the bug It's a bug and we should do something about it. label Jan 31, 2025
@mthh
Copy link
Member Author

mthh commented Jan 31, 2025 •
edited
Loading

It turns out that we're using GDAL (via gdal3.js) without support for XLS files (it needs to be compiled against FreeXL).

The simplest solution to the problem would be to change the documentation / input formats to no longer support XLS. This seems acceptable to me, given that we support XLSX (for Microsoft users), ODS (for LibreOffice / OpenOffice users) and CSV / TSV.

@rCarto WDYT ? Are you OK for totally removing the (currently broken) support for XLS files ?

@rCarto
Copy link
Member

rCarto commented Jan 31, 2025

Yes!

mthh added a commit that referenced this issue Feb 3, 2025
@mthh
Remove support for XLS files (fixes #148)
2f78125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug It's a bug and we should do something about it.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rCarto @mthh