-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to print result parts to console #56
base: main
Are you sure you want to change the base?
Conversation
src/api/printable_result.py
Outdated
def get_str_value(self) -> str: | ||
stringifier = ConsoleStringifier(c.configuration.to_stringifier_config()) | ||
return stringifier.create_str_value(self._result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be beneficial to also have access to the value and the uncertainties as numeric values, not only as strings? For example,
res = wiz.res(3.14, ...)
# Some further calculation
print(res.value + 1.0)
In this case, we should make very clear in the docs that the object returned by wiz.res()
is non-modifiable, e.g. you cannot set res.value = 42
afterwards and expect the underlying value to change. It is read-only.
But maybe that is overkill and we should leave it at strings. One could also argue that the user already knows the numerical value upfront, so they could instead just assign it the a local variable before passing it to wiz.res()
and would be good to go... This would also avoid confusion about the modifiability ob the object returned by wiz.res()
since when you only get back strings, you probably don't expect that this would modify the underlying valueres.value = "42.0"
. In that case, maybe we can even drop the "str" part of the method names? Since the datatype is clear by the method signature -> str
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But maybe that is overkill and we should leave it at strings.
I agree :-)
Resolve #28