Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numpy types #27

Open
Splines opened this issue Mar 24, 2024 · 2 comments
Open

Support numpy types #27

Splines opened this issue Mar 24, 2024 · 2 comments
Assignees

Comments

@Splines
Copy link
Collaborator

Splines commented Mar 24, 2024

Pass in a np.mean(my_numpy_array) value to wiz.res() and it'll work fine. However, Pylance complains that we don't have a matching overload for res which is true. We should allow numpy types, e.g. numpy.float64 and so on since numpy is so widely used in scientific research. Maybe there's a generic numpy number type that one could employ.

Note that "it'll work fine" is of course only true if the user has installed numpy (which is reasonable when they pass in a numpy value). But we should check for that and issue an error if that is not the case (suggest that user should install numpy).

@Splines
Copy link
Collaborator Author

Splines commented Apr 11, 2024

Feel free to check this issue out @paul019

@Splines
Copy link
Collaborator Author

Splines commented Apr 12, 2024

I posted a StackOverflow question for this.

@Splines Splines self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant