Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken selection panel UI for (at least) custom data? #8777

Closed
teh-cmc opened this issue Jan 22, 2025 · 0 comments · Fixed by #8790
Closed

Broken selection panel UI for (at least) custom data? #8777

teh-cmc opened this issue Jan 22, 2025 · 0 comments · Fixed by #8790
Assignees
Labels
🏹 arrow concerning arrow 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 22, 2025

If you look at the recording resulting from this thing:

rr.init("rerun_example_any_values_send_columns", spawn=True)

timestamps = np.arange(0, 64)

# Log two components, named "sin" and "cos", with the corresponding values
values = rr.AnyValues(
    sin=np.sin(timestamps / 10.0),
    cos=np.cos(timestamps / 10.0),
)

rr.send_columns(
    "/",
    times=[rr.TimeSequenceColumn("step", timestamps)],
    components=values.as_component_batches(),
)

what you'll see is that on 0.21 it shows what you'd expect:
Image

whereas on latest main is not only doesn't show what you'd expect, what it shows is just plain wrong (that's the size of the whole column, not this specific value at this specific timestamp):
Image

@teh-cmc teh-cmc added ui concerns graphical user interface 🏹 arrow concerning arrow 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release 🪳 bug Something isn't working labels Jan 22, 2025
@teh-cmc teh-cmc added this to the 0.22 - Entity filtering milestone Jan 22, 2025
@emilk emilk assigned emilk and unassigned emilk Jan 22, 2025
@emilk emilk self-assigned this Jan 23, 2025
teh-cmc pushed a commit that referenced this issue Jan 23, 2025
### Related
* Closes #8777

The problem was using the wrong function to calculate the size of the
buffer (using the size of the whole buffer, rather than just the part we
are slicing).

I decided to also update the docs for `SizeBytes` and improve the size
estimation of `Vec` and friends to take capacity into account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants