Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same grpc:// client for both Storage Node and re_grpc_server #8761

Open
emilk opened this issue Jan 21, 2025 · 0 comments
Open

Use the same grpc:// client for both Storage Node and re_grpc_server #8761

emilk opened this issue Jan 21, 2025 · 0 comments
Labels
dataplatform Rerun Data Platform integration enhancement New feature or request

Comments

@emilk
Copy link
Member

emilk commented Jan 21, 2025

As a user, I want to write rerun grpc://some-ip and not care if what I'm talking to is re_grpc_server or the storage node.

Right now SN and re_grpc_server has no overlap in functionality, but eventually they will (e.g. both should be able to list a catalogue of recordings in it).

This will fix the temp:// schema thing added in

We could use a REST-like url parsing scheme, e.g. grpc://ip/recording/recording-id vs grpc://ip/events, and have that decide which rpc endpoint is hit.

We should probably unify the two gRPC clients regardless, since eventually there will be overlap in functionality between the two servers.

@emilk emilk added dataplatform Rerun Data Platform integration enhancement New feature or request labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant