Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict Yttrium and Sodium #88

Open
ViacheslavEfimenko opened this issue Feb 3, 2025 · 6 comments
Open

Conflict Yttrium and Sodium #88

ViacheslavEfimenko opened this issue Feb 3, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ViacheslavEfimenko
Copy link

Hi, when I'm trying update the library from 1.0.4 to 1.2.1, get compile error, because Yttrium have conflict, we use Sodium in project and this dependencies are in conflict.

Image

Can u helping with this issue on library lvl?

@ViacheslavEfimenko ViacheslavEfimenko added the enhancement New feature or request label Feb 3, 2025
Copy link

linear bot commented Feb 3, 2025

@marcelsalej
Copy link

+1. Same problems in our project that uses Sodium. Any pointers how to solve the thing?

@marcelsalej
Copy link

marcelsalej commented Feb 3, 2025

My suspicion is that the Yttrium should not create module.modulemap, as this is the general modulemap. It should have custom name(img below).

Image

Multiple .xcframework files could each contain their own module.modulemap, which might cause Xcode to fail when trying to process both at once. This could lead to the error you're seeing.

Solution: You need to ensure that the module.modulemap files are not conflicting, either by modifying them (as mentioned previously) or excluding one from the build.

@llbartekll llbartekll self-assigned this Feb 4, 2025
@marcelsalej
Copy link

@llbartekll any news on this? Can we expect the fix soon? Just to know how to proceed with this... Deadline for migration to reown is 17th of february as far as i read.

@llbartekll
Copy link
Collaborator

@marcelsalej hey, yes, I'll try to resolve it this week.

fyi: https://github.com/reown-com/reown-swift/releases/tag/1.1.1 does not depend on yttrium, so you can upgrade to 1.1.1 before deprecation. Anyway I'll prioritise to resolve the conflict asap.

@marcelsalej
Copy link

@llbartekll Yes correct. Works on version 1.1.1. Will test this instance and adapt code, so that we can update later when fix merged.

Thank you for your swift response 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants