Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probes do not store all oversampling information #249

Open
hoogerheide opened this issue Jan 22, 2025 · 0 comments
Open

Probes do not store all oversampling information #249

hoogerheide opened this issue Jan 22, 2025 · 0 comments

Comments

@hoogerheide
Copy link
Contributor

This issue is actually two-fold:

  1. General Probe objects (e.g. NeutronProbe) store oversampling information, but only general oversampling, not oversampling created with the critical_edge function.
  2. QProbe (frequently used with data from facilities that do not produce dTheta / dLambda data explicitly from reduction) does not store oversampling information at all.

The impact of this is that oversampling information is lost when deserializing a serialized model (e.g. from a session history), and the fit results are different than the saved value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant