Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultProps Deprecated (And Causing Warnings) #168

Closed
jwalkerinterpres opened this issue May 7, 2024 · 2 comments · Fixed by #171
Closed

defaultProps Deprecated (And Causing Warnings) #168

jwalkerinterpres opened this issue May 7, 2024 · 2 comments · Fixed by #171
Assignees

Comments

@jwalkerinterpres
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[X] Other... Please describe: Warning report

Current behavior

image
image
etc.

Expected behavior

The console should be free of warnings.

Minimal reproduction of the problem with instructions

  1. Use any of the Rea Blocks components listed here: https://github.com/search?q=repo%3Areaviz%2Freablocks%20defaultProps&type=code
  2. See the warnings shown above

What is the motivation / use case for changing the behavior?

Signal to noise ratio: when my console is filled with warnings, it's harder to find the information I'm looking for in it.

Environment


Libs:
- react version: 18.2.0
- reablocks version: 5.10.14


Browser:
Irrelevant (warnings appear in all browsers/versions, as far as I know)

For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@ghsteff ghsteff self-assigned this May 8, 2024
@ghsteff ghsteff linked a pull request May 8, 2024 that will close this issue
2 tasks
@jwalkerinterpres
Copy link
Author

Y'all rock, thanks for addressing this!

@ghsteff
Copy link
Contributor

ghsteff commented May 8, 2024

Y'all rock, thanks for addressing this!

No problem! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants