-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tests to new API #7
Conversation
Once this gets merged to
Bumping the version to 0.2.0 signals a breaking change, which is important because by removing the deprecations you make the old API not work anymore. |
Bump. It would be nice to get a release with these changes. If you're unsure of how to do such things, I personally would recommend transferring this package to JuliaMath (see #4) so that others can take on the maintenance burden for this package. |
Bump |
@rdoelman, would you like help with the items in #7 (comment)? If you invite me to collaborate on this repo I can take those steps. |
That would be very much appreciated! I've added you. |
Thanks! Looks like there may be one step you'll have to take: can you click the "Install app" button on https://github.com/JuliaRegistries/Registrator.jl?tab=readme-ov-file#via-the-web-interface. You'll likely have to choose whether you want to install it on all your repositories or just a select subset. I've chosen it for all of mine: When that's done, I think I'll have permissions for the rest, so let me know when it's ready. |
I've taken care of it. |
It works! JuliaRegistries/General#115980 |
This copies the old tests to
tests/deprecations.jl
and updatesruntests.jl
to use the new API. The main tests pass even withjulia --depwarn=error
(though it will error when itinclude
s thetest/deprecations.jl
file).