Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Override config values #67

Closed
HamasakiBrain opened this issue Sep 16, 2024 · 3 comments
Closed

[Feature Request]: Override config values #67

HamasakiBrain opened this issue Sep 16, 2024 · 3 comments

Comments

@HamasakiBrain
Copy link

Feature Description

Override Config Values

You can easily override default config values by adding them to the override option in config/setting.php, thereby eliminating the need to modify the default config files and also allowing you to change said values during production. Ex:

'override' => [
    "app.name" => "app_name",
    "app.env" => "app_env",
    "mail.driver" => "app_mail_driver",
    "mail.host" => "app_mail_host",
],

The values on the left corresponds to the respective config value (Ex: config('app.name')) and the value on the right is the name of the key in your settings table/json file.

Is this feature valuable for other users as well and why?

If the library supports redefinition of configuration values, it is easily integrated with other third-party packages that may also offer their own configuration capabilities. This reduces the likelihood of conflicts and makes the system more compatible and extensible.

@HamasakiBrain
Copy link
Author

@HamasakiBrain
Copy link
Author

@rawilk

@rawilk
Copy link
Owner

rawilk commented Oct 16, 2024

Hey, I'm not sure I'm interested in implementing this kind of feature at this time for the package. I personally don't really have a need to do it like that, and it's not something I want to maintain right now. In the future I may revisit this, but for now I think I'll pass on it.

@rawilk rawilk closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants