Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to use Settings::all() on larave 9.5 and package v2.2.2 #43

Closed
josiahke opened this issue Oct 23, 2023 · 4 comments
Closed

unable to use Settings::all() on larave 9.5 and package v2.2.2 #43

josiahke opened this issue Oct 23, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@josiahke
Copy link

josiahke commented Oct 23, 2023

Laravel Settings

2.2.2

Laravel Version

9.52

Bug description

unable to use Settings::all()
unable to install v3 on Laravel 9

Steps to reproduce

No response

Relevant log output

No response

@josiahke josiahke added the bug Something isn't working label Oct 23, 2023
@josiahke josiahke changed the title unable to use Settings::all() unable to use Settings::all() on larave 9.5 and package v2.2.2 Oct 23, 2023
@dnkmdg
Copy link

dnkmdg commented Oct 24, 2023

I experience the same issue - with following response:

Md5KeyGenerator does not support removing the context from the key

Pointing to /vendor/rawilk/laravel-settings/src/Settings.php:203-216

image

@rawilk
Copy link
Owner

rawilk commented Nov 1, 2023

The all() method was introduced with in v3. Due to how v2 handles setting keys, I can't think of a way to make it available for v2 without it introducing a breaking change.

@rawilk
Copy link
Owner

rawilk commented Nov 1, 2023

@dnkmdg The default Md5KeyGenerator is not allowed to be used for retrieving all settings; you need to use the ReadableKeyGenerator instead, or a custom key generator, which can be set on the key_generator configuration key in config/settings.php.

If this isn't clear in the docs, I may need to update them to better explain this.

For more information on this, please see: https://randallwilk.dev/docs/laravel-settings/v3/advanced-usage/custom-generators#user-content-keygenerator

@rawilk
Copy link
Owner

rawilk commented Nov 14, 2023

Hey, I'm going to close this issue since there hasn't been any activity on it for a little while. Feel free to re-open the issue if you still need help.

@rawilk rawilk closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants