Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing cached, contextual settings issue #3

Closed
rawilk opened this issue Oct 26, 2020 · 1 comment
Closed

Storing cached, contextual settings issue #3

rawilk opened this issue Oct 26, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rawilk
Copy link
Owner

rawilk commented Oct 26, 2020

When caching is enabled, the Settings class will first retrieve the current value for a given key and determine if it has changed. This isn't an issue under most cases, unless you're using context. Since Settings is using the get method to retrieve the current value, the context gets reset in that method, thus causing any further code to ignore the context Settings was given. Since it does that, Settings will not be aware of any context when it generates the setting key when it goes to persist the setting.

Context

  • Package version: 1.0.2
  • Laravel version: 8.11.2
@rawilk rawilk added the bug Something isn't working label Oct 26, 2020
@rawilk rawilk self-assigned this Oct 26, 2020
@rawilk
Copy link
Owner Author

rawilk commented Oct 26, 2020

Resolved with version 1.0.3

@rawilk rawilk closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant