User Model Context not used a second time

[ismaail]

Laravel Settings

v2.2.2

Laravel Version

v10.15.0

Bug description

We have a array of settings to save per User

$input = [
  'api_key' => 'AAAA',
  'api_secret' => 'BBBB',
];

The first one api_key gets saved and the Context here is
the Model User Class Name & the User's id

The second one api_secret is also saved, but the Context is NULL

The result is api_secret gets shared by all Users!

Steps to reproduce

1. Add HasSettings Trait to the User Model

2. Log-in so we can has a User Model as the Context

3. prepare some settings to save (from a request mostly)

$input = [
  'api_key' => 'AAAA',
  'api_secret' => 'BBBB',
];

Save the Settings

$settings = \Auth::user()->settings();
// or $settings = $request->user()->settings();

foreach ($input as $key => $value) {
  $settings->set($key, $value);
}

Relevant log output

No response

[github-actions]

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[ismaail]

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 7 days.

bad bot

[github-actions]

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[rawilk]

The reason why the context is lost on your model in that foreach loop is because the underlying settings service resets the context after each call. For this reason, I would just call it like this in your loop:

foreach ($input as $key => $value) {
    auth()->user()->settings()->set($key, $value);
}