Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Laravel 10 support #14

Closed
maicol07 opened this issue Feb 19, 2023 · 1 comment
Closed

[Feature Request]: Laravel 10 support #14

maicol07 opened this issue Feb 19, 2023 · 1 comment

Comments

@maicol07
Copy link

Feature Description

Hi,
will you support Laravel 10?
Thanks

Is this feature valuable for other users as well and why?

No response
@maicol07 maicol07 mentioned this issue Feb 20, 2023
Closed
@rawilk rawilk mentioned this issue Mar 20, 2023
Merged
@rawilk
Copy link
Owner

rawilk commented Mar 20, 2023

Laravel 10.x is being added today. Sorry for delay, I've been working on an update to another package I maintain.

Also, thanks for taking the time to raise an issue and create a PR to fix it. The only reason I didn't merge yours is because the testbench versions don't match with laravel 10.x, so the tests aren't going to work properly.

@rawilk rawilk closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow Laravel 10 in composer.json (#14) maicol07/laravel-settings
2 participants
@maicol07 @rawilk