Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rancher Cluster Templates not applying labels #51

Open
shabazzfsher opened this issue Jan 23, 2025 · 1 comment
Open

Rancher Cluster Templates not applying labels #51

shabazzfsher opened this issue Jan 23, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@shabazzfsher
Copy link

RGS customer is experiencing an issue with the AWS cluster template in the Rancher Cluster Templates Helm chart (v0.6.1). Labels and taints defined in the values.yaml file are not being applied to clusters as expected. The issue seems to originate in the AWS template file:
https://github.com/rancherfederal/rancher-cluster-templates/blob/rancher-cluster-templates-0.6.1/charts/cluster-templates/templates/nodeconfig-aws.yaml

  • The nodepools section starts at line 3, but it doesn’t handle labels or taints.
  • The nodepool section, starting at line 122, does include logic for labels and taints, but it doesn’t align with the way the values.yaml file is structured.

Additionally, the values-aws.yaml file only includes a nodepools section, with no mention of nodepool:
https://github.com/rancherfederal/rancher-cluster-templates/blob/rancher-cluster-templates-0.6.1/charts/cluster-templates/values-aws.yaml

This discrepancy results in labels and taints being ignored unless they are manually applied or the Helm template is adjusted accordingly.

@shabazzfsher shabazzfsher added the bug Something isn't working label Jan 23, 2025
@zackbradys
Copy link
Member

Hey @shabazzfsher... thanks for submitting this issue! I will take a look at why we they aren't being applied...

I don't believe the labels/taints/annotations not being applied will have to do with the nodepools vs nodepool You can see they are working as expected due to the code below:

{{- $clustername := .Values.cluster.name -}}
{{- if eq .Values.cloudprovider "amazonec2" }}
{{- range $index, $nodepool := .Values.nodepools }}

AND

{{ $nodepool := .Values.nodepool }}
{{- if $nodepool }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants