Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards proper unwinding #102

Merged
merged 15 commits into from
Jan 23, 2025
Merged

Towards proper unwinding #102

merged 15 commits into from
Jan 23, 2025

Conversation

gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Jan 22, 2025

Machinery is there now, "just" have to use it.

  • RParquetAppender.cpp
  • RParquetOutFile.cpp
  • RParquetReader.cpp
  • arrow-schema.cpp
  • base64.cpp
  • broken.cpp
  • cpp-utils.cpp
  • dictionary-encoding.cpp
  • encodings.cpp
  • protect.cpp
  • r-base64.cpp
  • r-utils.cpp
  • read-metadata.cpp
  • read-pages.cpp
  • read2.cpp
  • rwrapper.cpp
  • snappy.cpp
  • test.cpp
  • write2.cpp

We need to copy the error message out of the exception
object, so it can be destroyed before the `Rf_error()`
jump.
For now protect `Rf_error()` calls, those are the
most problematic.
@gaborcsardi
Copy link
Member Author

Actually, I am not going to properly fix all of these, because it is a lot. But I'll handle the memory errors that valgrind detected. It seems like I only need to wrap Rf_error() for them.

@gaborcsardi
Copy link
Member Author

Will be handled properly in #103.

@gaborcsardi gaborcsardi merged commit fb56834 into main Jan 23, 2025
15 checks passed
@gaborcsardi gaborcsardi deleted the fix/unwind branch January 23, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant