forked from hannes/miniparquet
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards proper unwinding #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to copy the error message out of the exception object, so it can be destroyed before the `Rf_error()` jump.
gaborcsardi
force-pushed
the
fix/unwind
branch
from
January 22, 2025 19:05
c5281bd
to
3800be5
Compare
For now protect `Rf_error()` calls, those are the most problematic.
Actually, I am not going to properly fix all of these, because it is a lot. But I'll handle the memory errors that valgrind detected. It seems like I only need to wrap |
Will be handled properly in #103. |
gaborcsardi
force-pushed
the
fix/unwind
branch
from
January 23, 2025 12:41
c74e489
to
1e3fe72
Compare
Probably harmless, but better to be sure.
A 32 bit shift should be surely ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Machinery is there now, "just" have to use it.