-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 2? #114
Comments
urllib3 does not use h11 (yet?) and will soon issue a v2 that drops Python 2 support anyway. We do use h11 in https://github.com/python-trio/hip that does support Python 2. I'd be happy to remove Python 2 support there too, but @njsmith has been opposed to it in the past. |
Yeah, even I'm running out of excuses to keep py2 support at this point :-) |
So are we OK with dropping Python 2 for the next version? I am willing to work on it if so. The reason I want to drop Python 2 is that I want to add inline type annotations to h11, like we did for wsproto, if that's desirable. It is possible to use type comments but that's painful. |
Yes, you can open a pull request to remove Python 2 support! (And another one later for type annotations, I guess) |
@bluetech I have a typed branch - I'll review your PR then push it up (although I'm aiming to merge the line ending PR and release before dropping Py2). |
Awesome. Feel free to add me as a reviewer. |
Done in v0.12.0 (2021-01-01). |
Looks like much of this comment could be removed now? There is no longer Lines 23 to 43 in fb6c715
|
would you mind opening this as a new issue / improvement / feature request ? |
Sure, please see #152. |
I'd like to drop support for Python 2, type hint this codebase, and make use of features like dataclasses. I've a local version where I've done this - to allow testing of mypyc (it does speed things up). I know around this time last year there was a need/desire to keep Python 2 support for urllib3 (have I remembered this correctly?). Is there still a motivating need for Python 2 support?
To clarify I think the status quo is currently fine, however if Python 2 isn't needed/desired then great.
The text was updated successfully, but these errors were encountered: