Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots won't work with pytest 5 #136

Open
pedrospdc opened this issue Oct 21, 2019 · 1 comment
Open

Screenshots won't work with pytest 5 #136

pedrospdc opened this issue Oct 21, 2019 · 1 comment

Comments

@pedrospdc
Copy link

In _browser_screenshot_session, you have the following code:


    fixture_values = (
        # pytest 3
        getattr(request, '_fixture_values', {}) or
        # pytest 2
        getattr(request, '_funcargs', {})
    )

    for name, value in fixture_values.items():

None of these getters are set in pytest 5.

@mpasternak
Copy link
Contributor

Is the problem still applicable? We're on pytest 7 and the code seems to be working just fine. Please let me know if this is still a problem, or even better, submit a PR with fix. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants