Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logfire._internal from logfire-api #828

Open
samuelcolvin opened this issue Jan 29, 2025 · 1 comment
Open

Remove logfire._internal from logfire-api #828

samuelcolvin opened this issue Jan 29, 2025 · 1 comment
Assignees

Comments

@samuelcolvin
Copy link
Member

Having the _internal sub-package is great as it provides a boundary to not include in the logfire-api package. We should remove it, it would also make the logfire-api package lighter.

@Kludex
Copy link
Member

Kludex commented Jan 29, 2025

I don't think we can do that unless we move the types around in logfire itself. We use mypy stubgen, and we purposely include internal to not lose some types.

Currently the logfire-api wheel size is 73.9 kB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants