CSV file from tutorial 4 not working [Bug]:

[rb902]

PyBaMM Version

23.5

Python Version

3.11 (64-bit)

Describe the bug

In tutorial 4, a csv file ("pybamm/input/drive_cycles/US06.csv") is pulled. Then the next step is the following code:
model = pybamm.lithium_ion.SPMe()
sim = pybamm.Simulation(model, parameter_values=parameter_values)
sim.solve()
sim.plot(["Current [A]", "Voltage [V]"])

It's supposed to return these graphs, according to the tutorial:

but I get this error:
SolverError: 't_eval' must be provided if not using an experiment or simulating a drive cycle. 't_eval' can be provided as an array of times at which to return the solution, or as a list [t0, tf] where t0 is the initial time and tf is the final time. For a constant current (dis)charge the suggested 't_eval' is [0, 3700/C] where C is the C-rate. For example, run

sim.solve([0, 3700])

for a 1C discharge.

the first time I tried it was also having issues with the voltage beingnegative at points. I plotted a quick graph of the voltage too:

Could you advise what is going on? Thanks!

Steps to Reproduce

I was literally just following tutorial 4: https://docs.pybamm.org/en/latest/source/examples/notebooks/getting_started/tutorial-4-setting-parameter-values.html

Relevant log output

No response

[brosaplanella]

I tried this both locally and on Google Colab and it worked fine (Google Colab had a small error as it is installing v23.5 but running the example from develop branch, but running the next cells worked fine). Please try again and check that you haven't modified the notebook inadvertently.

Transferring this to a discussion, we can continue the conversation there.

[Saransh-cpp]

I faced an error in the develop branch while updating the parameter values. Should they instead be updated like this? -

parameter_values.update({"Current function [A]": 10})
parameter_values.update({"Open-circuit voltage at 100% SOC [V]": 3.4}, check_already_exists=False)
parameter_values.update({"Open-circuit voltage at 0% SOC [V]": 3.0}, check_already_exists=False)

[brosaplanella]

I think this will be fine in next release as the parameter sets will include these parameters.

[rb902]

Ah yes I did do that when doing the code, sorry forgot to mention. the error I reported still comes up. Sent from Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Saransh Chopra ***@***.***> Sent: Monday, August 7, 2023 6:35:48 PM To: pybamm-team/PyBaMM ***@***.***> Cc: rb902 ***@***.***>; Author ***@***.***> Subject: Re: [pybamm-team/PyBaMM] CSV file from tutorial 4 not working [Bug]: (Discussion #3246) I faced an error in the develop branch while updating the parameter values. Should they instead be updated like this? - parameter_values.update({"Current function [A]": 10}) parameter_values.update({"Open-circuit voltage at 100% SOC [V]": 3.4}, check_already_exists=False) parameter_values.update({"Open-circuit voltage at 0% SOC [V]": 3.0}, check_already_exists=False) — Reply to this email directly, view it on GitHub<#3246 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWOEUOA4YQEMHGHQGMBI6QDXUERPJANCNFSM6AAAAAA3HJ3CE4>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Saransh-cpp]

Which notebooks are you using, the develop one or the main one? For me, both of them are working fine. Make sure you are running the cells in the same order, or else jupyter will change the variable values.

[rb902]

I'm sure i was running them in the right order but I will have a look and get back to you tomorrow - I was just copying and pasting them into jupyter notebook but didn't have any issues eith any of the other tutorials Sent from Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Saransh Chopra ***@***.***> Sent: Monday, August 7, 2023 7:29:14 PM To: pybamm-team/PyBaMM ***@***.***> Cc: rb902 ***@***.***>; Author ***@***.***> Subject: Re: [pybamm-team/PyBaMM] CSV file from tutorial 4 not working [Bug]: (Discussion #3246) Which notebooks are you using, the develop one or the main one? For me, both of them are working fine. Make sure you are running the cells in the same order, or else jupyter will change the variable values. — Reply to this email directly, view it on GitHub<#3246 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWOEUOFWKTNYHKG2YDPIJZDXUEXXVANCNFSM6AAAAAA3HJ3CE4>. You are receiving this because you authored the thread.Message ID: ***@***.***>