Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(experiment) consider removing Makefiles #16

Closed
jaxxstorm opened this issue Jun 3, 2020 · 2 comments
Closed

(experiment) consider removing Makefiles #16

jaxxstorm opened this issue Jun 3, 2020 · 2 comments
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@jaxxstorm
Copy link
Contributor

One of the more frustrating elements of the build process is dealing with the Makefile syntax we're currently using:

  • It's difficult to generate Makefiles programmatically
  • The syntax doesn't lend itself well to multi stage builds
  • It's quickly becoming complex

Ideally, we could try and replace this with a task runner which will allow us to generate these files programmatically with jk.

I've had some success before with https://github.com/go-task/task which uses a YAML config file, so we should try it out

@jaxxstorm jaxxstorm changed the title experiment: consider removing Makefiles (experiment) consider removing Makefiles Jun 3, 2020
@jkodroff
Copy link
Member

jkodroff commented Jan 26, 2022

Also:

  • We don't use proper file targets in Make, which results in unnecessary work being done.
  • Updating 60+ providers manually is a lot of toil.
  • Make does not work in PowerShell, requiring the use WSL on Windows.

@danielrbradley danielrbradley added resolution/fixed This issue was fixed kind/engineering Work that is not visible to an external user labels Jun 1, 2022
@danielrbradley
Copy link
Member

Fixed in #195 based on exploration work in pulumi/pulumi-awsx#859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants