Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devicetree serial-number as fallback for product_serial from DMI tables #691

Open
septatrix opened this issue Jan 2, 2025 · 2 comments

Comments

@septatrix
Copy link

(I am not sure if this better belongs here or node-exporter, feel free to move the issue to the other repo.)

On most ARM devices there are no DMI tables and when using things like u-boot emulating UEFI they are still incomplete. Thus /sys/class/dmi/id/product_serial is not available/empty. Alternatively, however, /sys/firmware/devicetree/base/serial-number is usually available on those devices and also contains a serial number. In case the former does not exists it should fall back to the latter.

@discordianfish
Copy link
Member

I don't know about this nor what 'devicetree' is exactly, but instead of falling back we should probably explicilty expose devicetree entries, so the caller of procfs can decide how to reach e.g serial numbers

@septatrix
Copy link
Author

They are a mechanism for Linux to obtain data about the hardware and are widely used on e.g. ARM in the absence of UEFI.

The exposed serial numbers semantically represent the same thing as those in the DMI tables for UEFI machines. As such other projects like systemd also treat them equivalent

I would also be fine with exposing them separately in this lower level module. In that case however I would also create an issue at the node-exporter repo to treat them equivalently there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants