Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stopping a running ping with a Context #14

Open
sector-f opened this issue Sep 28, 2022 · 2 comments
Open

Allow stopping a running ping with a Context #14

sector-f opened this issue Sep 28, 2022 · 2 comments

Comments

@sector-f
Copy link

It could be helpful if there were a method like *Pinger.Run() that accepted a Context for cancellation. Would this be difficult to add given the current implementation?

@TheRushingWookie
Copy link
Contributor

Hi I'd be interested in adding support for this. Would you guys be open to me adding a PR for it?

It'd look like

The API would look like:

func (p *Pinger) Run(ctx context.Context) error 

@TheRushingWookie
Copy link
Contributor

This is implemented in #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants