Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint action for pull requests. #2

Closed
jpeach opened this issue Oct 4, 2020 · 2 comments · Fixed by #3
Closed

Add golangci-lint action for pull requests. #2

jpeach opened this issue Oct 4, 2020 · 2 comments · Fixed by #3
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jpeach
Copy link
Contributor

jpeach commented Oct 4, 2020

Please describe the problem you have

Add https://github.com/golangci/golangci-lint-action to this repository so that all the repositories in the organization can get it for automatically. One risk is that upgrading the linter version here affects all repositories, but I'm inclined to think that we can like with that.
@jpeach jpeach added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 4, 2020
@jpeach
Copy link
Contributor Author

jpeach commented Oct 4, 2020

@Glyphack Are you interested in duplicating projectcontour/contour#2976 to this repository?

@Glyphack
Copy link
Contributor

Glyphack commented Oct 5, 2020

Ofc. @jpeach

@Glyphack Glyphack mentioned this issue Oct 5, 2020
Merged
@jpeach jpeach closed this as completed in #3 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add golangci lint GH action to run on pull requests
2 participants
@jpeach @Glyphack