From 74ff49404856bbeced9433a72ee79ab18d2e9977 Mon Sep 17 00:00:00 2001 From: Greg Lauckhart Date: Sun, 24 Nov 2024 13:05:03 -0800 Subject: [PATCH] Remove redundant obsolete code --- .../access-control/AccessControlServer.ts | 39 ------------------- 1 file changed, 39 deletions(-) diff --git a/packages/node/src/behaviors/access-control/AccessControlServer.ts b/packages/node/src/behaviors/access-control/AccessControlServer.ts index 07add1568..a40bd4594 100644 --- a/packages/node/src/behaviors/access-control/AccessControlServer.ts +++ b/packages/node/src/behaviors/access-control/AccessControlServer.ts @@ -243,45 +243,6 @@ export class AccessControlServer extends AccessControlBehavior { for (const change of computeAclChanges(actor, oldValue, value)) { this.events.accessControlExtensionChanged.emit(change, this.context); } - const { session } = this.context; - - // TODO: This might be not really correct for local ACL changes because there the session fabric could be - // different which would lead to missing events of the relevant entries - const relevantFabricIndex = session?.associatedFabric.fabricIndex; - - if (relevantFabricIndex === undefined || this.events.accessControlExtensionChanged === undefined) { - return; - } - const adminPasscodeId = session === undefined || session?.isPase ? 0 : null; - const adminNodeId = adminPasscodeId === null ? session?.associatedFabric.rootNodeId : null; - if (adminNodeId === undefined) { - // Should never happen - return; - } - - const fabricExtensions = value.filter(entry => entry.fabricIndex === relevantFabricIndex); - const oldFabricExtensions = oldValue.filter(entry => entry.fabricIndex === relevantFabricIndex); - - const changeType = - fabricExtensions.length > oldFabricExtensions.length - ? AccessControlTypes.ChangeType.Added - : fabricExtensions.length < oldFabricExtensions.length - ? AccessControlTypes.ChangeType.Removed - : AccessControlTypes.ChangeType.Changed; - - this.events.accessControlExtensionChanged.emit( - { - changeType, - adminNodeId, - adminPasscodeId, - latestValue: - (changeType === AccessControlTypes.ChangeType.Removed - ? oldFabricExtensions[0] - : fabricExtensions[0]) ?? null, - fabricIndex: relevantFabricIndex, - }, - this.context, - ); } /**