Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] test-dcl-server.py Missing in Test Harness(Version: v2.12-beta2+spring2025 Sha: 41b4745) for TC-CGEN-2.12 Validation #530

Open
Rajashreekalmane opened this issue Feb 13, 2025 · 7 comments
Assignees
Labels

Comments

@Rajashreekalmane
Copy link

Rajashreekalmane commented Feb 13, 2025

Describe the bug

The test-dcl-server.py file is missing in the Test Harness, preventing the validation of the TC-CGEN-2.12 test case. This script is required for execution.
https://github.com/project-chip/connectedhomeip/blob/master/examples/chip-tool/commands/dcl/test_dcl_server.py
Image

Environment

Version: v2.12-beta2+spring2025
Sha: 41b4745

@Rajashreekalmane Rajashreekalmane added Bug Something isn't working Needs Triage labels Feb 13, 2025
@Rajashreekalmane Rajashreekalmane changed the title [Bug] test-dcl-server.py Missing in Test Harness for TC-CGEN-2.12 Validation [Bug] test-dcl-server.py Missing in Test Harness(Version: v2.12-beta2+spring2025 Sha: 41b4745) for TC-CGEN-2.12 Validation Feb 13, 2025
@antonio-amjr antonio-amjr self-assigned this Feb 13, 2025
@antonio-amjr
Copy link
Contributor

Hi @Rajashreekalmane,

I couldn't find any TC-CGEN-2.12 test available in the repos.
Can you point me out where is this test? Was it a typo?

Let me know and please share any information about this test-dcl-server.py script.

@Rajashreekalmane
Copy link
Author

@antonio-amjr The TC-CGEN-2.12 test case is not automated, so it won’t be available in the Python testing directory or YAML repo. This test case needs to be validated manually.

Here are the relevant references for validation:

Test Plan: TC-CGEN-2.12
Validation Instructions: GitHub PR #37049

Let me know if you need any further details.

@antonio-amjr
Copy link
Contributor

@Rajashreekalmane,

That helps. I'll take a look.
I already managed to copy the test-dcl-server.py on a chip-cert-bins image test locally.
We will confirm if we should create another SDK image and when.

Let me see if I handle verifying the script and TC-CGEN-2.12 with those links you shared.
I'll be back soon.

@antonio-amjr
Copy link
Contributor

Hey @Rajashreekalmane,

Sharing more about this issue. Executing the test-dcl-server.py, I noticed the following error:

./examples/chip-tool/commands/dcl/test_dcl_server.py 
Generating self-signed certificates...
...+.+..+++++++++++++++++++++++++++++++++++++++*....+...+..+.........+...+......+.+......+..+.......+........+.......+...+...+.....+...+..........+..+++++++++++++++++++++++++++++++++++++++*....+......+......+...+...................+.....+.......+...+..+......+...+.+.........+.........+..+...+.+...........+.............+..+.+.....+.........+.+...+.........+...............+..+...+...+....+......+..+.............+........+.+......+............+..+.+..............+......+...+.......+...+....................+.+...+.....+............+.+..+.+......+.....+....+..+...+....+..+...+...+.........+....+.....+.......+.....+....++++++
...+......+....+...+........+......+.........+.+.....+.+++++++++++++++++++++++++++++++++++++++*.....+.........+...+............+...+......+++++++++++++++++++++++++++++++++++++++*..+......+............+............+......+....+...+...+...........+.+...........................+...+.....+....+........+.......+.....+...+..........+........+...+............+.......+...+..+.+......+...+...............+......+.....+.........+.+......+........++++++
-----
Traceback (most recent call last):
  File "/Users/aamj/dev/connectedhomeip/./examples/chip-tool/commands/dcl/test_dcl_server.py", line 245, in <module>
    run_https_server()
  File "/Users/aamj/dev/connectedhomeip/./examples/chip-tool/commands/dcl/test_dcl_server.py", line 217, in run_https_server
    httpd.socket = ssl.wrap_socket(
                   ^^^^^^^^^^^^^^^
AttributeError: module 'ssl' has no attribute 'wrap_socket'

It seems that the script presents this error when using python3.
There's already a draft PR#37549 on the SDK side that solves it (tested locally) and should enter so it may work properly.

I'll see with the team what approach we should do in this case.

@Rajashreekalmane
Copy link
Author

Thanks, @antonio-amjr, That sounds good. I'll wait for your confirmation on whether a new SDK image is needed. I noticed that v2.12-beta3+spring2025 was recently released—do you know if the fix is included in this version?

@antonio-amjr
Copy link
Contributor

No, the v2.12-beta3+spring2025 does not have the fix. I don't have any updates on that either.
Since the PR#37549 is still a draft and I don't know when it'll be ready, so even adding the script to the apps/ it'll still have this error I mentioned above.

@antonio-amjr
Copy link
Contributor

antonio-amjr commented Feb 14, 2025

The PR#37549 was merged on the master branch of SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants