Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow critical Banner variant to use onDismiss #5582

Open
brphelps opened this issue Jan 21, 2025 · 0 comments · May be fixed by #5583
Open

Allow critical Banner variant to use onDismiss #5582

brphelps opened this issue Jan 21, 2025 · 0 comments · May be fixed by #5583
Labels
bug Something isn't working component: Banner enhancement New feature or request react

Comments

@brphelps
Copy link

Description

Currently, the Banner component doesn't allow onDismiss to be used if the critical variant is used.

We would like to be able to use the onDismiss button when using the critical variant.

Steps to reproduce

Add a Banner component and configure variant as critical and onDismiss as non null.

Version

v37.9.1

Browser

No response
@brphelps brphelps added the bug Something isn't working label Jan 21, 2025
@brphelps brphelps linked a pull request Jan 21, 2025 that will close this issue
Open
13 tasks
@joshblack joshblack changed the title Allow Banner to use onDismiss Allow critical Banner variant to use onDismiss Jan 21, 2025
@joshblack joshblack added enhancement New feature or request component: Banner labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component: Banner enhancement New feature or request react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Banner allows critical variant to use ondismiss brphelps/react
2 participants
@joshblack @brphelps