From d24c81075f8ffda3aaa92a43cdcd1b25bf9004f8 Mon Sep 17 00:00:00 2001
From: prajwalch <prajwal.chapagain58@gmail.com>
Date: Mon, 9 Sep 2024 06:25:45 +0545
Subject: [PATCH] refactor(App): Storing `ArgMatches` is redundant

Signed-off-by: prajwalch <prajwal.chapagain58@gmail.com>
---
 README.md   |  2 +-
 src/App.zig | 13 +++----------
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/README.md b/README.md
index 7854c8b..2a4be2b 100644
--- a/README.md
+++ b/README.md
@@ -195,7 +195,7 @@ Once you have finished adding all the arguments and subcommands, call `App.parse
 to start parsing the arguments given to the current process. This function internally utilizes
 [`std.process.argsAlloc`](https://ziglang.org/documentation/master/std/#A;std:process.argsAlloc)
 to obtain the raw arguments. Alternatively, you can use `App.parseFrom()` and pass your own raw 
-arguments, which can be useful during testing. Both functions return a constant pointer to
+arguments, which can be useful during testing. Both functions returns
 [`ArgMatches`](https://prajwalch.github.io/yazap/#A;lib:ArgMatches).
 
 ```zig
diff --git a/src/App.zig b/src/App.zig
index 0584070..e8554eb 100644
--- a/src/App.zig
+++ b/src/App.zig
@@ -18,11 +18,6 @@ command: Command,
 ///
 /// It is not intended for direct access, use `ArgMatches` instead.
 parse_result: ?ParseResult = null,
-/// Public container to query parse result.
-///
-/// It cab be access directly but for the most part `parseFrom` or `parseProcess`
-/// returns it.
-arg_matches: ?ArgMatches = null,
 /// Raw buffer containing command line arguments.
 process_args: ?[]const [:0]u8 = null,
 
@@ -58,7 +53,6 @@ pub fn deinit(self: *App) void {
     }
     self.command.deinit();
     self.parse_result = null;
-    self.arg_matches = null;
 }
 
 /// Creates a new `Command` with given name and optional description.
@@ -105,7 +99,7 @@ pub fn rootCommand(self: *App) *Command {
 ///
 /// const matches = try app.parseProcess();
 /// ```
-pub fn parseProcess(self: *App) YazapError!(*const ArgMatches) {
+pub fn parseProcess(self: *App) YazapError!ArgMatches {
     self.process_args = try std.process.argsAlloc(self.allocator);
     return self.parseFrom(self.process_args.?[1..]);
 }
@@ -124,7 +118,7 @@ pub fn parseProcess(self: *App) YazapError!(*const ArgMatches) {
 ///
 /// const matches = try app.parseFrom(&.{ "arg1", "--some-option" "subcmd" });
 /// ```
-pub fn parseFrom(self: *App, argv: []const [:0]const u8) YazapError!(*const ArgMatches) {
+pub fn parseFrom(self: *App, argv: []const [:0]const u8) YazapError!ArgMatches {
     var parser = Parser.init(self.allocator, argv, self.rootCommand());
     var result = parser.parse() catch |err| {
         // Don't clutter the test result with error messages.
@@ -143,8 +137,7 @@ pub fn parseFrom(self: *App, argv: []const [:0]const u8) YazapError!(*const ArgM
     }
 
     self.parse_result = result;
-    self.arg_matches = ArgMatches{ .parse_result = &self.parse_result.? };
-    return &self.arg_matches.?;
+    return ArgMatches{ .parse_result = &self.parse_result.? };
 }
 
 /// Displays the overall usage and description of the application.