Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build run forever (vscode insiders 1.22.0) #97

Closed
jbeaudoin11 opened this issue Mar 17, 2018 · 14 comments
Closed

Build run forever (vscode insiders 1.22.0) #97

jbeaudoin11 opened this issue Mar 17, 2018 · 14 comments

Comments

@jbeaudoin11
Copy link

jbeaudoin11 commented Mar 17, 2018

Temporary solution

This is a known bug in VSCode 1.22 microsoft/vscode#47350

Please downgrade to VSCode 1.21 using https://code.visualstudio.com/updates/v1_21 and "Download" links


Hi !

Every time i try to build in vscode insiders 1.22.0 the build is just running forever like it's frozen :
image

I can't even ctrl+c to end it.. it doesn't response..
Tried with the latest stable build of vscode 1.21.1 and it works as expected.

Version 1.22.0-insider
Commit 9160e85b1ab0333dfe697032f90da494f1f81fd4
Date 2018-03-16T06:17:01.718Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

@chenjingyuanku
Copy link

I have the same problem as you。

@jbeaudoin11
Copy link
Author

Actually it's every task.. not just build.
But yeah it's pretty annoying i need to use vs code 1.21 instead

@Super169
Copy link

Super169 commented Apr 6, 2018

I have the same issue with vscode 1.22.1, it has generated a wrong command for build & upload

If I enter "platformio run" in terminal, it can build the project correctly. So the installation of platformio is correct.

But when I press Ctrl-Alt-B, it will generate the command as "< source path >\platformio.exe run", which cannot build the project.

@jbeaudoin11
Copy link
Author

Yeah i noticed that !

@ivankravets
Copy link
Member

So, the issue is linked with VSCode. Let's wait for their comments on that. See microsoft/vscode#47350 (comment)

@cyberman54
Copy link

same issue here.

@ivankravets
Copy link
Member

See updated comment #97 (comment) for a temporary solution.

@dbaeumer
Copy link

dbaeumer commented Apr 9, 2018

@ivankravets Sorry for that. I investigated and I know what broke it. See microsoft/vscode#47350 (comment)

I will work on a fix and will add the fix to our next recovery build. There is something in the Platform IO extension you can do to work around this bug which brings the fix faster to your customers. Simply make the path to the platformio.exe absolute (only needed under Windows). Then the findExecutable code used to find a executable on a Path under Windows is not executed (under Linux and Mac the code never executed since the OS finds an executable on the path). On line https://github.com/platformio/platformio-vscode-ide/blob/develop/src/tasks.js#L261 path.join platformio.exe with the install location of Platform IO which on my machine is C:\Users\dirkb\.platformio\penv\Scripts

I apologize for the swirl that this is causing.

@dbaeumer
Copy link

dbaeumer commented Apr 9, 2018

Alternatively the users of the Platform IO extension could add the path to the 'Scripts' to their path environment variable.

I started to debug why this is broken and the problem is that I when VS Code tries to find the executable the C:\Users\dirkb\.platformio\penv\Scripts is not on the PATH in my system (e.g. the renderer) but it is in the terminal. Need to understand why this is the case.

@dbaeumer
Copy link

dbaeumer commented Apr 9, 2018

I delivered a fix to master which will be included in the next insider build. I will also propose the fix to be included in the next recovery build.

@dbaeumer
Copy link

dbaeumer commented Apr 9, 2018

We decided to include the fix into the recovery build. However I still recommend that the Platfrom IO extension makes the path absolute since it might take a couple of days before the recovery build is released.

@ivankravets
Copy link
Member

Please upgrade to v0.14.1. The temporary workaround was added.

@dbaeumer
Copy link

@ivankravets thanks for releasing a workaround. Appreciated!

@ivankravets
Copy link
Member

@dbaeumer Thank you too! We can't wait for a new Tasks API when it will be released. I saw it in Insider version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants