Gradle 8 compatibility: replace execResult -> executionResult #55
Conversation
|
@zbynek any idea when you might merge this PR that resolve the gradle 8 issue? |
|
@mohammad-haque I don't have merge rights in this repo. Meanwhile you can maybe test my PR with Jitpack. |
|
@piotrmadry will you have time to check this? |
|
Would be great if we can get this merged 🙇 |
| @@ -43,7 +43,7 @@ class FirebaseTestLabPlugin : Plugin<Project> { | |||
| isIgnoreExitValue = true | |||
|
|
|||
| doLast { | |||
| execResult?.let { | |||
| executionResult?.let { | |||
There was a problem hiding this comment.
executionResult returns a provider now and is non-nullable.
if (executionResult.get().exitValue != 0) {
println(standardOutput.toString())
throw GradleException("exec failed; see output above")
}
|
@tassilo-posegga I updated this PR with your suggestion, thanks! As the README meanwhile says, this plugin is no longer maintained. EDIT: I released a fork of this plugin that includes this PR and #53 -- If you want to use it you can just update the plugin ID in your Gradle files, see https://plugins.gradle.org/plugin/io.github.zbynek.firebase for details. My understanding is that as of Gradle 8 with the latest Android plugin it's possible to use Firebase devices directly, so hopefully this plugin won't be needed for much longer. However, I still think it's useful to have at least one release of this plugin compatible with Gradle 8 to make incremental update of tooling possible. Closing this PR since repo is no longer maintained. |
Fixes #54