Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting a vote on bugs.php.net results with a blank page #112

Closed
mvorisek opened this issue Dec 5, 2021 · 3 comments
Closed

Submitting a vote on bugs.php.net results with a blank page #112

mvorisek opened this issue Dec 5, 2021 · 3 comments

Comments

@mvorisek
Copy link

mvorisek commented Dec 5, 2021

I did some experiments and it seems the issue is present when user is connected via IPv6. Database column length is probably too short.

@nikic
Copy link
Member

nikic commented Dec 5, 2021

Looking at the error log, it's even worse:

$ip = ip2long(get_real_ip());
returns false and gets converted to empty string and we get an SQL syntax error :)

@cmb69
Copy link
Member

cmb69 commented Jul 20, 2024

… unless there is an X-Forwarded-For header involved, in which case the function might not return at all:

if (!eregi ("^(10|172\.16|192\.168)\.", $ips[$i]) &&

Anyhow, I don't think it makes sense to fix that voting functionality. Maybe we should drop it altogether, see PR #120,

cmb69 added a commit to cmb69/web-bugs that referenced this issue Jul 20, 2024
@derickr
Copy link
Member

derickr commented Jul 31, 2024

Will be addressed as part of #114 and #120

@derickr derickr closed this as completed Jul 31, 2024
derickr pushed a commit that referenced this issue Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants